Update Benchmark Action #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 190 190
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikeingold
approved these changes
Jul 24, 2025
Collaborator
|
Looks like a nice improvement! I just wanted to confirm: is this one ready for merge? |
Member
Author
|
Yes, it is. Don't worry about not receiving the comment from the bot. It will appear for the next PR. It's expected that it doesn't appear in the PR, where it is added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, there is an official benchmark action script provided by AirspeedVelocity.jl, which simplifies the workflow significantly and has some nice features (like also measuring the allocations), see https://github.com/MilesCranmer/AirspeedVelocity.jl#using-in-ci.